search

chrisvxd / story2sketch

Convert Storybook into Sketch symbols 💎
Other
403 stars 32 forks source link

Upgrade html-sketchapp to v2.0.0 #15

Closed kojiwakayama closed 6 years ago

kojiwakayama commented 6 years ago

Closes https://github.com/chrisvxd/story2sketch/issues/8 and https://github.com/chrisvxd/story2sketch/issues/14

kdzwinel commented 6 years ago

html-sketchapp is now available on npm so I suggest pulling it from there ;)

kojiwakayama commented 6 years ago

Thanks! @kdzwinel

kdzwinel commented 6 years ago

@kojiwakayama np! 2.0.0 does introduce a breaking change though (sorry, I should have mentioned that), so updating to 2.0 may require a bit more work. Update to 1.1.1 should be painless if you don't want to go into 2.0 changes.

kojiwakayama commented 6 years ago

Oh, thanks for letting me know @kdzwinel I changed the version to 1.1.1 for now. Looking now into the upgrade to 2.0.

kojiwakayama commented 6 years ago

Upgraded to 2.0 @kdzwinel @chrisvxd

chrisvxd commented 6 years ago

Hey @kojiwakayama! Thanks for the PR! I’m on holiday at the moment but will test this out when I’m next at a computer, either later this week, or the next week at the latest.

chrisvxd commented 6 years ago

Excellent work, thanks @kojiwakayama!