chrisvxd / story2sketch

Convert Storybook into Sketch symbols 💎
Other
403 stars 32 forks source link

Add note on "Navigation timeout exceeded" #19

Closed nettiopsu closed 5 years ago

nettiopsu commented 6 years ago

Hello, I am trying to export a Storybook, which has 38 examples

For some reason, it goes through 4 of them and then it collapses on error Navigation Timeout Exceeded: 30000ms exceeded

According to the source code, it happens in getSymbolsForStory:

await page.goto(builtUrl, { waitUntil: "networkidle2" });

and it says before showing timeout error: TypeError: Cannot read property 'goto' of undefined

I tried to change the order of storiesOfComponent, but it always stops on 4th page no matter what. 4 generated pages look completely fine after using exported file in Sketch

Any ideas on it? Is it puppeteer issue?

chrisvxd commented 6 years ago

Hey @nettiopsu! I've also encountered this in the past, and solved it by tweaking the concurrency.

Could you try reducing the concurrency to 2 or 1? https://github.com/chrisvxd/story2sketch#api

Background: story2sketch runs a headless chrome instance with multiple tabs. Concurrency controls the number of open tabs at any one time.

nettiopsu commented 6 years ago

@chrisvxd it actually worked when I used 2 for the concurrency! thanks for that and your tool, very useful!

hopefully, someone will find this issue in github useful

chrisvxd commented 6 years ago

Glad that worked! I think I'll update the docs and consider changing the default value. I think, generally, the concurrency shouldn't exceed the number of available cores. So a default of 2 would make more sense for most machines.

chrisvxd commented 5 years ago

Closing in favour of #67