search

chriswailes / RLTK

The Ruby Language Toolkit
http://chriswailes.github.io/RLTK/
University of Illinois/NCSA Open Source License
453 stars 35 forks source link

Fix tests (limited filigree version) #52

Closed pnomolos closed 7 years ago

pnomolos commented 7 years ago

Using filigree 0.4.0 was breaking tests (and presumably code) on master. Limit to less than 0.4.0 to fix that :)

chriswailes commented 7 years ago

The changes to Filigree were made in conjunction with the changes that I'm currently making in the RLTK dev branch. I can either incorporate this patch and push another point release of RLTK, or I can hurry up and finish RLTK 4.0. Thoughts?

pnomolos commented 7 years ago

Hi Chris,

I would recommend doing another point release since the friction to do so is minimal (I hope?). That way if someone can’t upgrade to RLTK 4 they won’t run into problems down the road if they accidentally upgrade filigree to 0.4+ On Mon, Oct 30, 2017 at 9:22 AM Chris Wailes notifications@github.com wrote:

The changes to Filigree were made in conjunction with the changes that I'm currently making in the RLTK dev branch. I can either incorporate this patch and push another point release of RLTK, or I can hurry up and finish RLTK 4.0. Thoughts?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chriswailes/RLTK/pull/52#issuecomment-340499497, or mute the thread https://github.com/notifications/unsubscribe-auth/AACNfwv5VBI5jxa2UNkdnO81WAbuSPdOks5sxffHgaJpZM4QKDWy .