Fix: Disposed logs - Githubissues

chriswalz / bit

Bit is a modern Git CLI

Apache License 2.0

6.05k stars 106 forks source link

Closed 0xc0d closed 3 years ago

0xc0d commented 3 years ago

Added Send call to Event, without it, the logs won't show up. Send is equivalent to calling Msg("").

chriswalz commented 3 years ago

So these lines are not actually logging anything? What caused you to make this change?

0xc0d commented 3 years ago

No actually! without Msg nothing will happen! Nothing happened. Just reviewing the code, and found this issue!

chriswalz commented 3 years ago

@0xc0d I verified your changes, that's a bit embarrassing :P. Thanks for the PR!

0xc0d commented 3 years ago

Anytime! Don't worry! I think the design is so confusing xD!