search

chriswarren / desk

A Ruby wrapper for the Desk.com V2 REST API
MIT License
66 stars 80 forks source link

Hashie fixed version giving conflicts #69

Closed thomasbalsloev closed 4 years ago

thomasbalsloev commented 7 years ago

Hi.

Back in issue #60 the Hashie gem was fixed to a specific version to avoid breakage in the desk gem.

This version fix is however causing fallout now where the Hashie gem continues to develop with breaking changes.

Specifically the version lock ion #60 is now causing a conflict inn our app with e.g. the Zendesk gem where Hashie version >=3.5.2 is demanded due to a bug fix involving the breaking changes in Hashie 3.5.2.

With every new Hashie version this problem of conflicts will increase.

Is there any chance for an update to allow Hashie >=3.5.2 support?

Best regards, Thomas Balsløv.

chriswarren commented 7 years ago

If you'd like to make a pull request with the necessary changes I'd be happy to pull it in. Please make sure the test suite passes. Thanks!

On May 29, 2017, 03:40 -0500, P9GIT notifications@github.com, wrote:

Hi. Back in issue #60 the Hashie gem was fixed to a specific version to avoid breakage in the desk gem. This version fix is however causing fallout now where the Hashie gem continues to develop with breaking changes. Specifically the version lock ion #60 is now causing a conflict inn our app with e.g. the Zendesk gem where Hashie version >=3.5.2 is demanded due to a bug fix involving the breaking changes in Hashie 3.5.2. With every new Hashie version this problem of conflicts will increase. Is there any chance for an update to allow Hashie >=3.5.2 support? Best regards, Thomas Balsløv. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

thomasbalsloev commented 4 years ago

Closing since we use official Desk.com gem.