chriswarren / desk

A Ruby wrapper for the Desk.com V2 REST API
MIT License
66 stars 80 forks source link

Get back the :type key for mashes in a forward-compatible way #70

Closed saverio-kantox closed 7 years ago

saverio-kantox commented 7 years ago

Relates to #60 and #69.

The issue basically was that the :type method was forcefully removed. Hashie removed :id and :type methods just because they were not part of ruby base anymore, so they were treated as normal key accessors. Removing the method from Mash itself prevented the :type key from being used.

Also, a standard disabling of warning is added to avoid noise for clashing class, first and entries keys:

saverio-kantox commented 7 years ago

The corresponding spec fails with current master.

chriswarren commented 7 years ago

Thanks!

chriswarren commented 7 years ago

Published as version 1.0.9