search

chriswertz / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUMMARY #5

Open rimmesbe opened 7 years ago

rimmesbe commented 7 years ago

Grade: Satisfactory

Summary: Nice job on this final project, the site looks good. The mobile also looks good. I see a lot of good techniques here and the html is well organized. The biggest issue I see is the css. The class names are really lacking: top, left, image, one, two, etc. these are not good names. You need to name classes for the components they are styling: .learning-section, .course-img, .column-left Also the selectors in the css file need to be simplified. Limit yourself to 2 chained selectors max, not to say you can't ever use more, but it will be good practice for you to not. Check out some css naming convention, there are many. I think it will help in both areas: http://getbem.com/introduction/

chriswertz commented 7 years ago

Thanks for this. I was struggling with what to name things. I realized after I submitted the project that I could have used some better naming conventions after looking at some other student's work. Additionally, I was getting confused with my chaining myself. However, I felt like I needed to put them in a certain order. 

If my code reads:
<div class="one">
  <div class="two">
    <div class="three>
    </div>
  </div>
</div>

Do I need ot write the CSS like this:
.one .two .three {
}

or can I just write it as:

.three {
]
chriswertz commented 7 years ago

I guess I should have asked this question in the slack community.