search

chriswetterman / sketch-find-and-replace-text

Find and replace text throughout your Sketch document
48 stars 5 forks source link

Feature request: Ability to just search & review before replace #19

Open UXfever opened 4 years ago

UXfever commented 4 years ago

Love the find and replace functionality, it would be superb it we are able to:

find the first occurence, being able to review if we 'd like to replace it. And use "Replace" or "Find Next" to continue the search

chriswetterman commented 4 years ago

This is currently how you can operate the plugin on a per-textfield basis. Are you looking to perform multiple search/replaces within a single field if the word phrase appears more than once?

lnajjar commented 3 years ago

Chris (@chriswetterman), I believe we are hoping to:

  1. Open your find tool
  2. Enter a text phrase
  3. Find the phrase in the displayed user interface text across either (a) the current page, or (b) all pages in the Sketch file
  4. Skip to each displayed user interface find text hit
  5. Decide whether to (a) perform a replace on the hit, or (b) skip a replace on the hit
  6. Cancel out of your find tool.

Are these features in your current version?

chriswetterman commented 3 years ago

@lnajjar Thanks for reaching out. Yes, these features are present. To note, when clicking Find Next the page where that element is should become selected and the element positioned center screen. I had seen times where it would not position the found element in view. This was all done via the Sketch API. I'll need to revisit the behavior and see what's changed in the API.

Are you having any issues on your end?

lnajjar commented 3 years ago

That's great news, Chris! Thanks for updating your plug-in. I wanted to see if it would meet my needs before downloading it. So, I have not used it yet.

lnajjar commented 3 years ago

@chriswetterman, I downloaded your plug-in and it works great! You are making a very valuable contribution to Sketch and helping me and many others get our work done.

On very busy, zoomed out pages, I had trouble finding the hits. If you want to make it even better, the only possible improvement I can see is to highlight each hit in an obvious way (like color, box, zoom).

But that is a nit. You have done wonderful work. Thank you very much.