search

chriswininger / FongPhone

GNU General Public License v2.0
1 stars 1 forks source link

Somewhere is our code is a self declaration without a var #33

Closed chriswininger closed 8 years ago

chriswininger commented 9 years ago

If you leave the var off the front of variable declaration it is hoisted to global.

Somewhere in our code this is happening with self and making self implicitly defined to window which can lead to weird hard to detect bugs.

We need to find and fix this. Already masked some strange things

chriswininger commented 8 years ago

guess self is actually defaulted to window, did not know that was a thing. learn something new everyday