search

chrisys / train-departure-display

A replica, near real-time, miniature UK railway station train departure sign based upon a Raspberry Pi Zero and 256x64 SPI OLED display
245 stars 76 forks source link

In some stations filtered platform data is incomplete due to only 3 rows being returned from the API #102

Closed CalamityJames closed 1 year ago

CalamityJames commented 1 year ago

Due to the National Rail API not supporting a native platform filter, it is done in the script. With rows set to the default of 3 and a platform filter in place, this sometimes returns less information than is actually available from the API, for example: image

Upping the rows to 10 (which is actually the upper limit for this API request) fixes that issue: image

image

My proposal would to just get as much information from the National Rail API as is available. I can't see it being too much of a performance hit, but thought I'd log this as an issue rather than just submitting a PR just to see what your thoughts were!

chrisys commented 1 year ago

Agree @CalamityJames I don't see why not!