Better token support and status logger

chrisz / pyhusmow

Control your Husqvarna automower

GNU General Public License v3.0

59 stars 29 forks source link

Better token support and status logger #9

Closed CaselIT closed 7 years ago

CaselIT commented 7 years ago

Hi @chrisz First of all thanks for writing this library!

I've added some changes for my own personal use, but I think some of them could be useful to others

The main changes are:

Better token support: once the server grant us a token we reuse it until it expires. This avoids the login and logout steps that were previously done for every request.
Added support for more than one mower
Added a logger to periodically log the status of the mower for a set number of days

Let my know if you have some suggestion

CaselIT commented 7 years ago

Hi @chrisz, when you have time, can you give me a feedback? Thanks

chrisz commented 7 years ago

Hi @CaselIT

Sorry for the delay, I'm a little bit busy these days.

I just checkout your branch. Review is ok and tests ok too :-).

Thank you for these improvements :-)

Chris

CaselIT commented 7 years ago

Thanks @chrisz Out of curiosity did you find a reference document for the husqvarna api, or did you just tried until it worked?

chrisz commented 7 years ago

No reference document but the apk "Automower Connect" contains a js file with the code of the application... so I just extract commands to write this script.

richardpub4136 commented 7 years ago

Do you know these elements from Husqvarna ?? https://github.com/husqvarnagroup/hcp

Personally I do not have enough skills but it seems to me that it describes quite precisely the operation of the application husqvarna

CaselIT commented 7 years ago

@richardpub4136 I've had a quick look at that repo, but I don't think its related to the rest api protocol. When I've time I'll take a closer look. Thanks for the heads up

chrisz commented 7 years ago

@richardpub4136 I agree with @CaselIT , I don't think we can use hcp to control automower using rest api. hcp seems to be a framework to control mowers at low level, maybe via the usb wire. And I have the impression that codecs are missing and without codec (specifications of commands), hcp is useless. But maybe I didn't understand this project.