search

chriszarate / supergenpass

A free bookmarklet password generator.
https://chriszarate.github.io/supergenpass/
GNU General Public License v2.0
418 stars 160 forks source link

SuperGenPass bookmarklet exceeds iCloud bookmark size limit #60

Closed cbowns closed 9 years ago

cbowns commented 9 years ago

My SuperGenPass bookmarklet no longer appears on my iPhone or iPad. I hit this issue with genpass back in the day, and finally looked into why: it's 4633 bytes, and iCloud has a per-bookmark size limit of 4kB.

cbowns commented 9 years ago

Simply running the bookmarklet through http://jsbeautifier.org and http://skalman.github.io/UglifyJS-online/ shrunk it to 2997 bytes.

cbowns commented 9 years ago

And once shrunk, it synced over to my devices just fine.

cbowns commented 9 years ago

Related issue filed on bookmarkleter as https://github.com/chriszarate/bookmarkleter/issues/4

It's odd that the SuperGenPass bookmarklet on supergenpass.com is 4.6 kB, but un- and re-compressing it with bookmarkleter yields a 3.4 kB bookmarklet.

chriszarate commented 9 years ago

Thanks. For some reason the current bookmarklet doesn't have any of it's variable names mangled, which is the main weight savings. Should be easy to fix.

chriszarate commented 9 years ago

Fixed in latest bookmarklet (20150216). It still URL-encodes so it's ~3.4 KB.

cbowns commented 9 years ago

:+1: thanks!