chriszarate / supergenpass

A free bookmarklet password generator.
https://chriszarate.github.io/supergenpass/
GNU General Public License v2.0
418 stars 160 forks source link

save current advanced options as defaults #79

Open dunc05 opened 8 years ago

dunc05 commented 8 years ago

Hi Chris,

Love SGP.

Have been using v2.0.1 for years but finally decided I needed a longer PWD so have installed the new bookmarklet.

I just can't seem to get 'save current advanced options as defaults' to work.

I change PWD length to 20 + pick SHA, click the save icon and it display a tick, but when I close it with the X and re-open its back to the default of 10 + MD5 capture

Tried in both FF 44 + Chrome 49 on Windows 10 x64

Any ideas ?

Thanks, Duncan.

chriszarate commented 8 years ago

The save feature uses the browser's localStorage. Does your browser's security settings allow the use of localStorage?

dunc05 commented 8 years ago

It seems to - see screenshots

localstoragechrome

localstoragefirefox

But when I use the bookmarklet on another page, the local storage is blank and trying to save it doesn't work:

differentpagechrome

chriszarate commented 8 years ago

I can replicate your issue in Chrome when Preferences > Advanced > Privacy > Content Settings > Cookies > "Block third-party cookies and site data" is checked. SGP in an iframe is, of course, third-party.

I can also replicate your issue in Safari when Preferences > Privacy > Cookies and website data > "Allow from current website only" is checked, and sometimes when "Allow from websites I visit" is checked.

Do any of those options apply to your browsers?

dunc05 commented 8 years ago

Hey Chris,

Yes, I have the same setting for Chrome (turning it off allows it to work)

I've tried to add an ALLOW exception - 'http://www.supergenpass.com/mobile/' which gets cut down to http://www.supergenpass.com

Doesn't seem to help - am I adding the right thing ? Does it work for you ?


The equivalent in Firefox seems to be about:preferences#privacy History Accept third-party cookies: From visited [changing to Always allows it to work]

Add an exception in FF doesn't help either

techunsupport commented 7 years ago

Just a stupid suggestion. but isn't the most important aspect that people want to save as default are the algorithm type and the length? So, why can't you pass that through the javascript/URI. Meaning, anyone can make multiple bookmarklets to fit whatever the destination website they need. If not then have a few options available instead of just one. Say one as is, and another with everything maxed out. I do not think anyone care much about MD5 anymore and having longer password is always better, so why not? Anyone going to use more advanced optional one surely smart enough to hit the delete key a few time if they need shorter password.

insysion commented 6 years ago

@dunc05 You need to add an exception for [*.]chriszarate.github.io and then it works

I've tried to add an ALLOW exception - 'http://www.supergenpass.com/mobile/' which gets cut down to http://www.supergenpass.com

Doesn't seem to help - am I adding the right thing ? Does it work for you ?

techunsupport commented 6 years ago

Thanks that would do it. Adding (allow) *[.]chriszarate.github.io in chrome, and https://chriszarate.github.io** for firefox would do the trick.