search

chrivers / bifrost

Hue Bridge Emulator
GNU General Public License v3.0
124 stars 6 forks source link

Add Docker install instructions #8

Closed ellwoodb closed 3 months ago

ellwoodb commented 3 months ago

Hey @chrivers, me again. Just got to writing some instructions for the Docker installation.

I tried to be as clear and simple as possible. I also tried to align the style to the rest of the readme, hopefully that worked. I also quickly ran it through a spellcheck, but if you find anything wrong, feel free to edit it.

Quick question: I saw there is a package now that we could use as an image. I haven't tried it yet, is it ready for me to add it to the readme and docker-compose? For now, I wrote it with only having the Dockerfile option.

If you encounter any problems, feel free to ask and make adjustments as you like.

chrivers commented 3 months ago

Thank you very much - this is great!

I reviewed your work, and have a few notes. I hope you're up for another round :)

ellwoodb commented 3 months ago

Sure, no problem. Did you already comment on some things, because I can't see it?

chrivers commented 3 months ago

Looking good!

Do you mind rebasing on top of master? I like to keep the git history reasonably clean :)

ellwoodb commented 3 months ago

Hey, not at Home right now, so I'll have to do that later.

I'm not very experienced with git and GitHub, do you mind pointing me in a direction on how to rebase / what you mean by that?

chrivers commented 3 months ago

Good news, I was able to rebase the branch from github :)

Thanks for the work, I'll merge it :+1:

ellwoodb commented 3 months ago

Perfect, glad to have helped! 👍