search

chrmarti / vscode-regex

MIT License
154 stars 32 forks source link

Feature/code lens option #24

Closed ergunsh closed 6 years ago

ergunsh commented 6 years ago

Hey!

I have found code lens showing in every regexp quite annoying, so added an option to toggle it.

You can disable code lens but can still use with keybinding.

Have a nice day!

chrmarti commented 6 years ago

Hi @ergun1017, thanks a lot for your contribution!

The current change requires restarting VS Code for a settings change to take effect. Maybe the code lens provider could always be registered and the function provideCodeLenses should then check the setting and return when it is disabled.

ergunsh commented 6 years ago

Any update on this?

chrmarti commented 6 years ago

Looks good! I'll probably change the default to enabled, that keeps it easy to discover. Users familiar with the feature can then opt to turn the code lens off.

I should find the time to publish a new version some time next week.

ergunsh commented 6 years ago

Cool! I'm actually really looking forward to this option. (currently I've disabled this extension in my workspace.. 😅)

chrmarti commented 6 years ago

It's released. Thanks for your contributions! (https://twitter.com/christof_marti/status/989885628199395329)