Regen JS Client API - Githubissues

tazarov commented 11 months ago

The JS client API seems to be a bit out of date with recent changes to FastAPI. It needs to be regenerated, and some of the JS tests refreshed.

jeffchuber commented 11 months ago

is something breaking or just types mismatch?

On Mon, Dec 18, 2023 at 1:07 AM Trayan Azarov @.***> wrote:

The JS client API seems to be a bit out of date with recent changes to FastAPI. It needs to be regenerated, and some of the JS tests refreshed.

— Reply to this email directly, view it on GitHub https://github.com/chroma-core/chroma/issues/1543, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGZWEAOJL6P2BLGPGUV4H3YKABUZAVCNFSM6AAAAABAZFS722VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DMMJQHA4DKOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tazarov commented 11 months ago

I did a fix in #1494 where I made errors returned by the API consistent:

Before:

//Chroma Errors
{
"error":"<type of error>",
"message":"<exception message>"
}
//Other errors
{
"error":"<type of error> + <error message>"
}

After:

{
"error":"<type of error>",
"message":"<exception message>"
}

I've noticed that the JS API did not have the message parameter (basically, a test was failing as the expected message was in error instead of the message attribute of the error response). I tried regenerating the client but got some errors, which might be related to the API changes.

This issue is just a placeholder for me to look at later on

chroma-core / chroma

Regen JS Client API #1543