Closed codetheweb closed 1 week ago
Please leverage this checklist to ensure your code review is thorough before approving
Can we just manually verify that the tests are still going through the state machine?
Thanks for double checking. I did some investigation and commit 0c052da fixes this branch to have the expected behavior (without impacting correctness, to my knowledge). Currently:
main
with the fast
preset: all rules except delete_by_ids()
are called (I'd consider this check to be currently broken in PRs)main
with the normal
preset: all rules are calledfast
preset: all rules are callednormal
preset: all rules are called(fast
is used for PR checks, normal
is used for releases)
going to open an issue on hypothesis to see if there's a way to assert rules are called a minimum number of times/if we can add that feature so this doesn't happen again
after these updates the state changes for both PersistEmbeddingsStateMachine
and EmbeddingStateMachine
lgtm
Hypothesis has made many improvements in the last few months, including closing issues like https://github.com/HypothesisWorks/hypothesis/issues/3618.
Hoping that this will fix the recent error
(https://github.com/chroma-core/chroma/actions/runs/9505770742/job/26201473178)
or at least provide a better place to start debugging from.
(Seems like this error may have started occurring after https://github.com/chroma-core/chroma/pull/2297 was merged.)
Note: hypothesis was originally pegged in https://github.com/chroma-core/chroma/pull/1760.