chroma-core / chroma

the AI-native open-source embedding database
https://www.trychroma.com/
Apache License 2.0
13.4k stars 1.14k forks source link

[TST] bump hypothesis #2343

Closed codetheweb closed 1 week ago

codetheweb commented 2 weeks ago

Hypothesis has made many improvements in the last few months, including closing issues like https://github.com/HypothesisWorks/hypothesis/issues/3618.

Hoping that this will fix the recent error

Data generation is extremely slow: Only produced 9 valid examples in 225.14 seconds (0 invalid ones and 744 exceeded maximum size). Try decreasing size of the data you're generating (with e.g. max_size or max_leaves parameters).

(https://github.com/chroma-core/chroma/actions/runs/9505770742/job/26201473178)

or at least provide a better place to start debugging from.

(Seems like this error may have started occurring after https://github.com/chroma-core/chroma/pull/2297 was merged.)

Note: hypothesis was originally pegged in https://github.com/chroma-core/chroma/pull/1760.

github-actions[bot] commented 2 weeks ago

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

codetheweb commented 1 week ago

Can we just manually verify that the tests are still going through the state machine?

Thanks for double checking. I did some investigation and commit 0c052da fixes this branch to have the expected behavior (without impacting correctness, to my knowledge). Currently:

(fast is used for PR checks, normalis used for releases)

going to open an issue on hypothesis to see if there's a way to assert rules are called a minimum number of times/if we can add that feature so this doesn't happen again

codetheweb commented 1 week ago

after these updates the state changes for both PersistEmbeddingsStateMachine and EmbeddingStateMachine lgtm