HammadB commented 2 weeks ago

Description of changes

Summarize the changes made by this PR.

Improvements & Bug fixes
- I overhauled the property tests for the log service. There were bugs and also it was underspecc'ed
- The main bug was the the len() being used was over collectionData not of the collectionData[C] in question.
- I added invariants using rapids "" action, which is the way to add invariants.
- The invariants check the log is as we expect and also the the collections we expect get returned
- I actually use the enumerationoffset in the model now
- The model will actually purge the log it has.
- The prop test will check the fields of its records for equality
New functionality
- This PR introduces the "Min compaction size" argument on GetCollectionsToCompact, making it so that the compactors can skip logs with only a handful of entries.
- This min compaction size is config for the compactor
- I updated the rust in memory log to respect the min size.
- The property test is extended to check that min_compaction_size works.

Other notes:

The log service types all use int where they should be uint. I added a cleanup task to go convert the incorrect types. The new type I introduce is correct.

Test plan

How are these changes tested?

[x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

None

github-actions[bot] commented 2 weeks ago

Please leverage this checklist to ensure your code review is thorough before approving

[ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
[ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
[ ] If appropriate, are there adequate property based tests?
[ ] If appropriate, are there adequate unit tests?
[ ] Should any logging, debugging, tracing information be added or removed?
[ ] Are error messages user-friendly?
[ ] Have all documentation changes needed been made?
[ ] Have all non-obvious changes been commented?
System Compatibility
[ ] Are there any potential impacts on other parts of the system or backward compatibility?
[ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
[ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

HammadB commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite