HammadB commented 2 weeks ago

Description of changes

Summarize the changes made by this PR.

Improvements & Bug fixes
- Makes sysdb an enum not dyn. We perfer an enum to dyn where the number of impls is fairly bounded - in this case 2 - the real one and a mock.
New functionality
- None

Test plan

How are these changes tested? Existing tests - this is a non-functional refactor.

[x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

github-actions[bot] commented 2 weeks ago

Please leverage this checklist to ensure your code review is thorough before approving

[ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
[ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
[ ] If appropriate, are there adequate property based tests?
[ ] If appropriate, are there adequate unit tests?
[ ] Should any logging, debugging, tracing information be added or removed?
[ ] Are error messages user-friendly?
[ ] Have all documentation changes needed been made?
[ ] Have all non-obvious changes been commented?
System Compatibility
[ ] Are there any potential impacts on other parts of the system or backward compatibility?
[ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
[ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

HammadB commented 2 weeks ago

Jun 17, 1:10 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.
Jun 17, 1:10 PM EDT: @HammadB merged this pull request with Graphite.