chroma-core / chroma

the AI-native open-source embedding database
https://www.trychroma.com/
Apache License 2.0
14.72k stars 1.23k forks source link

[BUG] Chroma crash with the new numpy version - update requirements.txt #2352

Closed itayB closed 3 months ago

itayB commented 3 months ago

Description of changes

Summarize the changes made by this PR.

github-actions[bot] commented 3 months ago

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

HammadB commented 3 months ago

Thanks for flagging we will cut a new release this week to patch this

itayB commented 3 months ago

Thanks for raising this. Was successfully able to reproduce, and this is due to Chroma using now deprecated generic types in some of our multimodal datatypes:

https://github.com/chroma-core/chroma/blob/cc790a76e9690d361bb5b3d8d33483b77e357358/chromadb/api/types.py#L102

This is an easy fix, but unfortunately on further testing I found that onnxruntime which is upstream of us is also broken by numpy 2.0.

Pinning the version is probably the way to go! Let's keep the previous requirement to be above 1.22.5, while introducing this new one too.

done, thanks

atroyn commented 3 months ago

same happens here now: #2356

I didn’t see this in my testing but will check again.

HammadB commented 3 months ago

Closing this in favor of #2360 since we needed a few additional changes and I didn't want to hold up the fix on a review cycle - I really appreciate the fix here @itayB