[BUG] Chroma crash with the new tenacity version - update requirement…

[itayB]

…s.txt

    import chromadb
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/chromadb/__init__.py:3: in <module>
    from chromadb.api.client import Client as ClientCreator
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/chromadb/api/__init__.py:7: in <module>
    from chromadb.api.models.Collection import Collection
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/chromadb/api/models/Collection.py:7: in <module>
    import chromadb.utils.embedding_functions as ef
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/chromadb/utils/embedding_functions.py:5: in <module>
    from tenacity import stop_after_attempt, wait_random, retry, retry_if_exception
/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/tenacity/__init__.py:653: in <module>
    from tenacity.asyncio import AsyncRetrying  # noqa:E402,I100
E   ModuleNotFoundError: No module named 'tenacity.asyncio'

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • ...
• New functionality
  • ...

Test plan

How are these changes tested?

• [ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

[github-actions[bot]]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
• [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• [ ] If appropriate, are there adequate property based tests?
• [ ] If appropriate, are there adequate unit tests?
• [ ] Should any logging, debugging, tracing information be added or removed?
• [ ] Are error messages user-friendly?
• [ ] Have all documentation changes needed been made?
• [ ] Have all non-obvious changes been commented?

  System Compatibility

• [ ] Are there any potential impacts on other parts of the system or backward compatibility?
• [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

  Quality

• [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[atroyn]

I notice that the import error here is from opt/hostedtoolcache/ - could this be a caching error unrelated to Chroma?

[itayB]

I notice that the import error here is from opt/hostedtoolcache/ - could this be a caching error unrelated to Chroma?

Chroma is using tenacity here: https://github.com/chroma-core/chroma/blob/main/chromadb/utils/embedding_functions.py#L5

The reason why you didn't see it - is because they already released another (fix) version:

[atroyn]

Good catch. I have the feeling that since so many modules are numpy dependent, we might have to freeze versions for the whole package to avoid a cascade of failures for our users.

If this happens a third time in the next 48 hours, I'll take a pass at that myself.

[atroyn]

Sorry, my fault for putting the wrong title prefix on the PR!

[HammadB]

I think this may no longer be required with the 8.4.1 release. I think tenacity 8.4.0 was just a botched release.

[HammadB]

Confirmed 8.4.1 works - I am going to close this out but please let me know if I am doing to incorrectly @itayB