chroma-core / chroma

the AI-native open-source embedding database

https://www.trychroma.com/

Apache License 2.0

13.4k stars 1.14k forks source link

[BUG] Lock numpy to < 2.0.0 across all reqs and pyproject.toml #2360

Closed HammadB closed 1 week ago

HammadB commented 1 week ago

Description of changes

Summarize the changes made by this PR.

Improvements & Bug fixes
- Numpy 2.0 has some type changes which break our code. This was flagged by @itayB in #2352 (Thank you!). We need to extend that PR a bit to include other requirements for the thin client, as well as the pyproject.toml.
- Note: We could fix these type issues but Onnxruntime does not yet support python 2.0 - which we depend on (https://github.com/microsoft/onnxruntime/issues/21063)
New functionality
- None

Test plan

How are these changes tested?

[x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

We may want to update our docs? I am not sure what makes sense here - input solicited.

github-actions[bot] commented 1 week ago

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

[ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
[ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
[ ] If appropriate, are there adequate property based tests?
[ ] If appropriate, are there adequate unit tests?
[ ] Should any logging, debugging, tracing information be added or removed?
[ ] Are error messages user-friendly?
[ ] Have all documentation changes needed been made?
[ ] Have all non-obvious changes been commented?
System Compatibility
[ ] Are there any potential impacts on other parts of the system or backward compatibility?
[ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
[ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

atroyn commented 1 week ago

Re: docs, I want to add a lot more detail in our contribution docs. I've started doing so on some of my other PRs, and I'll make a note to do it for dependency management as well.