Closed tazarov closed 1 week ago
Please leverage this checklist to ensure your code review is thorough before approving
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @tazarov and the rest of your teammates on Graphite
We don't usually make changes for sake of forward compatibility but this makes sense.
Don't we have to do this in other methods too - like get_collection?
What about list_collections?
What about https://github.com/chroma-core/chroma/blob/main/chromadb/api/async_fastapi.py?
Can we encapsulate this so we aren't repeating it everywhere?
cc @codetheweb
Done.
@HammadB, shouldn't dimension
and version
also make it into chromadb.api.models.CollectionCommon.CollectionCommon
, or are these for internal consumption?
@HammadB, shouldn't
dimension
andversion
also make it intochromadb.api.models.CollectionCommon.CollectionCommon
, or are these for internal consumption?
CollectionCommon is just a base class with some helpers that the async/sync variants inherent from. I don't think it needs to care about those fields unless I'm missing something.
@tazarov
Closes #2377 #2379
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
N/A