[ENH] get_or_create is really create_or_modify

chroma-core / chroma

the AI-native open-source embedding database

https://www.trychroma.com/

Apache License 2.0

13.36k stars 1.14k forks source link

[ENH] get_or_create is really create_or_modify #2390

Open atroyn opened 1 week ago

atroyn commented 1 week ago

Client.get_or_create_collection can also modify the returned collection, by passing new collection metadata. This behavior is confusing, and also relatively complex to implement.

We should instead ignore any parameters passed on the get_orcreate path, and rename these arguments on this path to `create...`.

atroyn commented 1 day ago

not sure what these comments have to do with this issue.