Closed atroyn closed 1 week ago
The original attempt to split up the embedding functions failed because of python 3.9 and 3.10 incompatibilities with issubtype.
issubtype
Original PR here: https://github.com/chroma-core/chroma/pull/2034
Failing tests here: https://github.com/chroma-core/chroma/actions/runs/9605053108/job/26491923410
The fix is changing issubtype to isinstance, which has the same functionality.
isinstance
Along with CI, tested locally with python 3.9 and 3.10 and confirmed passing.
N/A
Please leverage this checklist to ensure your code review is thorough before approving
Description of changes
The original attempt to split up the embedding functions failed because of python 3.9 and 3.10 incompatibilities with
issubtype
.Original PR here: https://github.com/chroma-core/chroma/pull/2034
Failing tests here: https://github.com/chroma-core/chroma/actions/runs/9605053108/job/26491923410
The fix is changing
issubtype
toisinstance
, which has the same functionality.Test plan
Along with CI, tested locally with python 3.9 and 3.10 and confirmed passing.
Documentation Changes
N/A