chroma-core / chroma

the AI-native open-source embedding database
https://www.trychroma.com/
Apache License 2.0
13.36k stars 1.14k forks source link

[BUG] 1965 Split up embedding functions - Redux #2395

Closed atroyn closed 1 week ago

atroyn commented 1 week ago

Description of changes

The original attempt to split up the embedding functions failed because of python 3.9 and 3.10 incompatibilities with issubtype.

Original PR here: https://github.com/chroma-core/chroma/pull/2034

Failing tests here: https://github.com/chroma-core/chroma/actions/runs/9605053108/job/26491923410

The fix is changing issubtype to isinstance, which has the same functionality.

Test plan

Along with CI, tested locally with python 3.9 and 3.10 and confirmed passing.

Documentation Changes

N/A

github-actions[bot] commented 1 week ago

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation