chroma-core / chroma

the AI-native open-source embedding database
https://www.trychroma.com/
Apache License 2.0
13.36k stars 1.14k forks source link

[BLD] use Depot to pre-build Docker images #2420

Open codetheweb opened 3 days ago

codetheweb commented 3 days ago

Extracted from https://github.com/chroma-core/chroma/pull/2393.

Somewhat surprisingly, it seems to only save ~15s (building locally vs. transferring image over network) but I think that gap will only widen in the future.

The speedup would also be far more substantial for the distributed tests that use Tilt, but unfortunately trying to do so results in a lot of strange bugs. Tilt claims the way to do this is with custom_build() instead of docker_build(), but after debugging for several hours I was unable to overcome strange bugs (related to caching I think). E.x. the first tilt up using custom_build()s succeeds, but the next invocation results in many containers spitting out messages like:

Error: failed to start container "migration": Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/bin/sh": stat /bin/sh: no such file or directory: unknown
github-actions[bot] commented 3 days ago

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation