codetheweb commented 2 months ago

Description of changes

Fixes get_target_block_id() to run in O(log n) instead of O(n). Shaves around 2.6s off total compaction time for 26k documents.

Test plan

How are these changes tested?

Covered by existing tests.

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

github-actions[bot] commented 2 months ago

Please leverage this checklist to ensure your code review is thorough before approving

[ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
[ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
[ ] If appropriate, are there adequate property based tests?
[ ] If appropriate, are there adequate unit tests?
[ ] Should any logging, debugging, tracing information be added or removed?
[ ] Are error messages user-friendly?
[ ] Have all documentation changes needed been made?
[ ] Have all non-obvious changes been commented?
System Compatibility
[ ] Are there any potential impacts on other parts of the system or backward compatibility?
[ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
[ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

HammadB commented 2 months ago

nice, good change. @sanketkedia can you TAL as well?