chroma-core / chroma

the AI-native open-source embedding database
https://www.trychroma.com/
Apache License 2.0
15.45k stars 1.3k forks source link

[BUG] Pull logs should fail if requested offset has been purged #2746

Closed sanketkedia closed 1 month ago

sanketkedia commented 2 months ago

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

Documentation Changes

None

github-actions[bot] commented 2 months ago

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

github-actions[bot] commented 2 months ago

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

sanketkedia commented 2 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on Graphite Graphite

sanketkedia commented 2 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on Graphite Graphite

sanketkedia commented 2 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on Graphite Graphite

HammadB commented 1 month ago

Would be nice to break the invariants up since this is so correctness-critical. Otherwise nice!