chroma-core / chroma

the AI-native open-source embedding database
https://www.trychroma.com/
Apache License 2.0
15.45k stars 1.3k forks source link

[ENH] Added http_client parameter to OpenAIEmbeddingFunction #2767

Closed weissgerber1 closed 2 months ago

weissgerber1 commented 2 months ago

Added support for a custom HTTP client in the OpenAIEmbeddingFunction class.

The change allows for providing an own HTTP client. Useful for SSL configuration, proxies or connection pooling.

Backwards compatibility is maintained as the OpenAI client will use its default HTTP client when provided with 'None'.

github-actions[bot] commented 2 months ago

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

jeffchuber commented 2 months ago

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.