Closed ishaksebsib closed 2 months ago
Please leverage this checklist to ensure your code review is thorough before approving
@ishaksebsib thanks for this! we are going to do a wholesale rewrite of the langchain docs this week. happy to still give you credit on the PR for finding this stuff! can we cut the code example entirely for now?
@ishaksebsib thanks for this! we are going to do a wholesale rewrite of the langchain docs this week. happy to still give you credit on the PR for finding this stuff! can we cut the code example entirely for now?
Hi @jeffchuber,
Thanks for the feedback. I've removed the code example as requested and updated the PR.
Let me know if there's anything else I can assist with. I'm also happy to help with the upcoming documentation rewrite if needed.
Description of changes
Improvements & Bug fixes
New functionality
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?