spikechroma commented 2 months ago

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

github-actions[bot] commented 2 months ago

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

github-actions[bot] commented 2 months ago

Please leverage this checklist to ensure your code review is thorough before approving

[ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
[ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
[ ] If appropriate, are there adequate property based tests?
[ ] If appropriate, are there adequate unit tests?
[ ] Should any logging, debugging, tracing information be added or removed?
[ ] Are error messages user-friendly?
[ ] Have all documentation changes needed been made?
[ ] Have all non-obvious changes been commented?
System Compatibility
[ ] Are there any potential impacts on other parts of the system or backward compatibility?
[ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
[ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

spikechroma commented 2 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikechroma and the rest of your teammates on Graphite

HammadB commented 2 months ago

Were you able to test this / confirm that onnxruntime released a supporting version to Pypi?

spikechroma commented 2 months ago

Were you able to test this / confirm that onnxruntime released a supporting version to Pypi?

microsoft/onnxruntime#21085

this is still in wip. let me test it today

spikechroma commented 2 months ago

Mac and Windows test passing for the numpy 1.26.0 and onnxruntime 1.19.2 numpy 2.1.1 and onnxruntime 1.19.2

HammadB commented 2 months ago

Closing in favor of #2811