HammadB commented 1 month ago

Description of changes

Summarize the changes made by this PR.

Improvements & Bug fixes
- Adds RequestVersionContext from #2827 to all segment type queries.
New functionality
- None

Test plan

How are these changes tested?

[x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

None

HammadB commented 1 month ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite

github-actions[bot] commented 1 month ago

Please leverage this checklist to ensure your code review is thorough before approving

[ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
[ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
[ ] If appropriate, are there adequate property based tests?
[ ] If appropriate, are there adequate unit tests?
[ ] Should any logging, debugging, tracing information be added or removed?
[ ] Are error messages user-friendly?
[ ] Have all documentation changes needed been made?
[ ] Have all non-obvious changes been commented?
System Compatibility
[ ] Are there any potential impacts on other parts of the system or backward compatibility?
[ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
[ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

HammadB commented 1 month ago

Sep 25, 1:54 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.
Sep 25, 2:00 PM EDT: Graphite rebased this pull request as part of a merge.
Sep 25, 2:01 PM EDT: @HammadB merged this pull request with Graphite.