Closed Sicheng-Pan closed 1 month ago
Please leverage this checklist to ensure your code review is thorough before approving
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @Sicheng-Pan and the rest of your teammates on Graphite
Description of changes
Summarize the changes made by this PR.
MetadataFilteringOperator
. Now it should produce the exact set of offset ids that should be contained in the result, so that the next operator can only focus on hydrating the offset ids.MetadataProvider
enum, which represents an universal interface for metadata access. Currently it can be constructed either from materialized logs or aMetadataSegmentReader
.RoaringMetadataFilter
trait, which helps to evaluate aWhere
clause given aMetadataProvider
.$ne
and$nin
are supported as part of this processTest plan
How are these changes tested?
This is guaranteed to break existing tests. Only the last PR in the stack addresses the breaking changes, and should pass the existing tests. In particular, any test involving the query node should fail because of compilation errors.
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A