search

chroma-sdk / Colore

A powerful C# library for Razer Chroma's SDK
https://chroma-sdk.github.io/Colore/
MIT License
146 stars 30 forks source link

Updating the Getting Started Guide #267

Closed leonardoInf closed 5 years ago

leonardoInf commented 5 years ago

...to reduce the steepness of the learning curve.

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.512.build.168 failed (commit https://github.com/chroma-sdk/Colore/commit/8b1fee96ef by @leonardoInf)

leonardoInf commented 5 years ago

well at least Travis seems to be fixed.

AppVeyorBot commented 5 years ago

:x: Build Colore 168-gwcwatfl failed (commit https://github.com/chroma-sdk/Colore/commit/8b1fee96ef by @leonardoInf)

Sharparam commented 5 years ago

Checking if the AppVeyor fails are just temporary errors. First one failed due to some unknown error with CodeCov, second seems to have failed to connect to GitHub somehow.

AppVeyorBot commented 5 years ago

:x: Build Colore 168-ayqitevy failed (commit https://github.com/chroma-sdk/Colore/commit/8b1fee96ef by @leonardoInf)

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.513.build.168 failed (commit https://github.com/chroma-sdk/Colore/commit/0d39a0cfe6 by @leonardoInf)

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.514.build.168 failed (commit https://github.com/chroma-sdk/Colore/commit/5b8e19ea65 by @leonardoInf)

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.515.build.168 failed (commit https://github.com/chroma-sdk/Colore/commit/3f45860428 by @leonardoInf)

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.516.build.168 failed (commit https://github.com/chroma-sdk/Colore/commit/ced0181e22 by @leonardoInf)

leonardoInf commented 5 years ago

Ok, I resolved all the issues which you legitimately pointed out.

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.518.build.168 failed (commit https://github.com/chroma-sdk/Colore/commit/b71818da42 by @leonardoInf)

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.519.build.168 failed (commit https://github.com/chroma-sdk/Colore/commit/9a4aeae1ee by @leonardoInf)

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.521.build.169 failed (commit https://github.com/chroma-sdk/Colore/commit/0596652ecb by @leonardoInf)

Sharparam commented 5 years ago

I pushed some more commits to the release branch to update Codecov versions and a minor change to the build script. Can you rebase again and see if AppVeyor is happy this time?

Also there is one remaining review comment above that isn't resolved yet about the three spaces and "Mous".

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.523.build.171 failed (commit https://github.com/chroma-sdk/Colore/commit/29c8ff2f7f by @leonardoInf)

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-PullRequest0267.524.build.171 failed (commit https://github.com/chroma-sdk/Colore/commit/e7d854d241 by @leonardoInf)

leonardoInf commented 5 years ago

I have rebased again. No hope for appveyor so far.. Btw, do you use a special software to find these typos?

Sharparam commented 5 years ago

I'm just looking through the diff manually and reviewing it :)

I'm raising an issue in the codecov repo to see if this is a bug in the tool itself.

Edit: Issue created here: codecov/codecov-exe#76

leonardoInf commented 5 years ago

oh, well i dont know what Ive messed up but it closed the issue for me..