chroma-sdk / Colore

A powerful C# library for Razer Chroma's SDK

https://chroma-sdk.github.io/Colore/

MIT License

146 stars 30 forks source link

Changed to use appveyor build number instead of version #272

Closed AdmiringWorm closed 5 years ago

AdmiringWorm commented 5 years ago

Due to incorrect documentation in the Cake.Codecov library, Appveyor.Version was incorrectly used instead of Appveyor.Number.

This Pull Request changes that to the correct variant.

AppVeyorBot commented 5 years ago

:x: Build Colore 6.1.0-pr0272.2.build.177 failed (commit https://github.com/chroma-sdk/Colore/commit/8cab302970 by @AdmiringWorm)

AppVeyorBot commented 5 years ago

:white_check_mark: Build Colore 6.1.0-pr0272.3.build.177 completed (commit https://github.com/chroma-sdk/Colore/commit/71ea5133f5 by @AdmiringWorm)

codecov-io commented 5 years ago

Codecov Report

Merging #272 into release/6.0.0 will not change coverage. The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/6.0.0     #272   +/-   ##
==============================================
  Coverage          55.76%   55.76%           
==============================================
  Files                 72       72           
  Lines               1820     1820           
  Branches             404      404           
==============================================
  Hits                1015     1015           
  Misses               736      736           
  Partials              69       69

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e11bca6...577d415. Read the comment docs.

AppVeyorBot commented 5 years ago

:x: Build Colore 177-smhdinbl failed (commit https://github.com/chroma-sdk/Colore/commit/e4b61fc455 by @AdmiringWorm)

AppVeyorBot commented 5 years ago

:x: Build Colore 177-yotqmrbm failed (commit https://github.com/chroma-sdk/Colore/commit/9f42a0703a by @AdmiringWorm)

AdmiringWorm commented 5 years ago

The failure is due to what seems like a connection problem with GitVersion and AppVeyor (when updating build version).

AppVeyorBot commented 5 years ago

:x: Build Colore 177-pvfscqrg failed (commit https://github.com/chroma-sdk/Colore/commit/ebcb44b3f4 by @AdmiringWorm)

Sharparam commented 5 years ago

Could be the force pushes confusing GitVersion, not sure. It has a tendency to break in some situations.

Thanks for looking into this and taking your time to find the issue! I'll merge this and ask for a rebase in the other PR and see if it works now :)

AdmiringWorm commented 5 years ago

Could be the force pushes confusing GitVersion, not sure. It has a tendency to break in some situations.

That is certainly possible.

Thanks for looking into this and taking your time to find the issue!

Not a problem at all.