IsSdkAvailable uses wrong registry path

WolfspiritM commented 3 years ago

Description

Since latest updates it seems like the SDK changed the path where the "Enable" flag is written to in the registry. The old path was "HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Razer Chroma SDK" the new one seems to be in the subkey "Apps".

For old installations the Enable flag that exists doesn't get removed so it keeps working there but new installs fail

Expected Behavior

Detect if the SDK is enabled or not

Actual Behavior

NullReferenceException as key.GetValue("Enable") returns null

Possible Fix

Check the new location

Steps to Reproduce

Delete Registry Key
Repair Synapse installation
Call IsSdkAvailable with the native SDK

Context

GameDog stopped working on fresh installed windows

Your Environment

Version of Colore used: 5 but 6 has the same issue
SDK mode (Native or REST API): Native
Synapse version installed: 3.6
Chroma SDK version in use: 3.20
Operating System and version (e.g. Windows 10 x64): Windows 10 x64
Link to your project (if available):

tgraupmann commented 3 years ago

Using registry checks is not the ideal way to check for this. Instead the Init and InitSDK API should be used. A zero success result means the Chroma SDK has initialized. A non-zero result means a failure.

Sharparam commented 3 years ago

@tgraupmann We want to explicitly check the availability without actually initializing the SDK, though.

chroma-sdk / Colore