search

chromakode / react-html-email

Create elegant HTML email templates using React.
MIT License
897 stars 115 forks source link

Use DOMProperty from react-dom instead of react #27

Closed ryanscottaudio closed 7 years ago

ryanscottaudio commented 7 years ago

This fixes an issue with the latest version of React (clearly a breaking change that was not marked as such).

Roilan commented 7 years ago

Assuming test pass, LGTM. 👍

@chromakode take a look as well

ryanscottaudio commented 7 years ago

per https://twitter.com/dan_abramov/status/798926305030877184, it might be good to find another workaround for this

chromakode commented 7 years ago

Yikes. We should add a fallback to getting it from react for older versions of React, and look for better solutions in the long-term.

I'll look into why the tests are failing.

chromakode commented 7 years ago

Testing this + a compat fix at https://github.com/chromakode/react-html-email/compare/fix-react-15-4

chromakode commented 7 years ago

@Roilan @ryanscottaudio Merged and released v1.1.3 which fixes this issue. Thanks!

mfeuermann commented 7 years ago

thx