chromakode / react-html-email

Create elegant HTML email templates using React.

MIT License

896 stars 115 forks source link

Add Row and Col components #33

Open wagnermoschini opened 7 years ago

wagnermoschini commented 7 years ago

this PR is inspired on @chromakode feedback on pr #21

//example of proposal
<Row>
  <Col>{...}</Col>
  <Col>{...}</Col>
</Row>

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@de060c8).

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de060c8...2cc06db. Read the comment docs.

singingwolfboy commented 6 years ago

@chromakode Any feedback on this? This pull request has been open for several months, and it looks really handy. Is it ready to be merged into master and released? If not, is there anything I can do to help make it ready?

robinknox commented 6 years ago

Likewise, I'd really like to see this functionality added since I need multi-column support for my emails.

chromaci commented 6 years ago

Thanks all for your thoughts in this thread. I'm presently traveling and will look into this over the weekend.

searls commented 6 years ago

+1 to taking a look at merging this. I think I'm going to probably work off a fork to get these two components since it seems necessary to do a 2-column layout

giulioambrogi commented 6 years ago

Any update on this?

kopax commented 5 years ago

Hi, any update on this? @chromaci vacation still?