search

chromakode / react-html-email

Create elegant HTML email templates using React.
MIT License
896 stars 115 forks source link

Warnings log even though warn is set to false #43

Open arasmussen opened 7 years ago

arasmussen commented 7 years ago

Here's my configuration:

import ReactHTMLEmail from 'react-html-email';

ReactHTMLEmail.injectReactEmailAttributes();
ReactHTMLEmail.configStyleValidator({
  strict: true,
  warn: false,
  platforms: [
    'gmail',
    'gmail-android',
    'apple-mail',
    'apple-ios',
  ],
});

Then here's the warning I get even though warn is set to false:

Warning: Failed prop type: Style property `border-radius` supplied to `A` unsupported in: gmail-android.
    in A (created by CTA)
    in CTA
    in tbody (created by Box)
    in table (created by Box)
    in Box (created by Email)
    in td (created by Item)
    in tr (created by Item)
    in Item (created by Email)
    in tbody (created by Box)
    in table (created by Box)
    in Box (created by Email)
    in body (created by Email)
    in html (created by Email)
    in Email

Am I doing something wrong?

rohan-deshpande commented 5 years ago

Did you get anywhere with this? I haven't been able to solve it either, it's annoying for tests, stubbing console.warn doesn't seem to help either somehow

arasmussen commented 5 years ago

Nope 😕

rohan-deshpande commented 5 years ago

Hmm, weird. Well I was wrong about the tests, they are using console.warn and console.error but the "error" messages have Warning: in them so I assumed they were warns. After stubbing both methods stuff doesn't get printed to the terminal anymore during tests.