chromakode / react-html-email

Create elegant HTML email templates using React.
MIT License
896 stars 115 forks source link

Using a number for width and height doesn't give us responsive images #61

Open nanomosfet opened 6 years ago

nanomosfet commented 6 years ago

Using a number for the width and height props forces you to know your image before hand.

If you supplied a string and then just passed it to the styles for the Image component it should render correctly even if you do '50%'. If I pass in styles from the Image component it even works but it gives a warning for prop types and it says you shouldn't assign width and height to div elements.

If you think its a good idea to make a change I can give it a go 👍