Separate ops & utils. - Githubissues

chromatix-team / chromatix

Differentiable wave optics using JAX! Documentation can be found at https://chromatix.readthedocs.io

MIT License

77 stars 13 forks source link

Separate ops & utils. #103

Closed GJBoth closed 1 year ago

GJBoth commented 1 year ago

This PR proposes a clearer separation between ops and utils. Simply:

functional contains only transformations Field -> Field
ops contains transformations not working on Fields, such as resampling, quantisation etc.
utils contains all the rest - but mostly it's stuff for shape broadcasting, dealing with grids and initialisers returning arrays.

diptodip commented 1 year ago

I moved the grid functions to utils instead of leaving a file just for grid functions and made the norm functions take an axis argument. I think it's better that we just have the norms be useful for any array and then there's no need to keep just two functions around in a separate grid utilities file, IMO.

GJBoth commented 1 year ago

Okay, I think I agree with that, I'll make the change.