search

chromatix-team / chromatix

Differentiable wave optics using JAX! Documentation can be found at https://chromatix.readthedocs.io
MIT License
77 stars 13 forks source link

Fix polarisation order. #132

Closed GJBoth closed 5 months ago

GJBoth commented 5 months ago

This fixes two things in the polarisation, as suggested by @gschlafly in #116

  1. It changes the order of the matrix-vector product. Previous behaviour was incorrect for asymmetric matrices.
  2. The polarisation matrices weren't normalised, leading to an increase in power. Now they're properly normalised
  3. Added tests for all this under left/right circular polarisers.