linear[bot]
commented
1 year ago AP-3575 Chromatic sign-in closes OAuth popup
#### How is the user affected? And what is the expected behavior? While connecting to Chromatic whilst not (yet) authenticated to Chromatic itself yet, the OAuth dialog closes as soon as you sign in to Chromatic, before you can finish the OAuth flow. When signing in to Chromatic as part of an OAuth flow, the user should be redirected back to that OAuth flow after signing in. #### How many and/or what class of users does this impact? Users of the Visual Test addon and Figma plugin who are not (yet) signed in to Chromatic. #### Is there a workaround? Sign in to Chromatic, then restart the OAuth flow. #### What are the steps for reproducing the issue? Sign out of Chromatic and sign out of the addon/plugin. Now connect the addon/plugin to Chromatic. After confirming the OAuth connection code, you are prompted to sign in to Chromatic. Once you do this, the OAuth popup closes automatically, making it impossible to finish the flow. #### Other information Fixing this might involve fixing the "redirect back to where you came from" problem we have in general.
tmeasday
Telescoping on https://github.com/chromaui/addon-visual-tests/pull/91 ✅
Relies on https://github.com/chromaui/chromatic/pull/7724 ✅ - ensure that after login the dialog doesn't auto close, instead it redirects you back to where you wanted to go (granting permission).
📦 Published PR as canary version:
0.0.86--canary.100.b09c8e2.0:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.86--canary.100.b09c8e2.0 # or yarn add @chromaui/addon-visual-tests@0.0.86--canary.100.b09c8e2.0 ```