chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Retrieve signed `captureImage` / `diffImage` URLs #108

Closed ghengeveld closed 12 months ago

ghengeveld commented 12 months ago

Depends on https://github.com/chromaui/chromatic/pull/7731

📦 Published PR as canary version: 0.0.78--canary.108.9cd47c7.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.78--canary.108.9cd47c7.0 # or yarn add @chromaui/addon-visual-tests@0.0.78--canary.108.9cd47c7.0 ```
linear[bot] commented 12 months ago
AP-3479 Snapshot images fail with 401 due to privacy settings (Safari)

After creating a new branch, applying some changes to a random component, committing those changes, and running the tests the addon fails to show the updated snapshot with the incoming change in the Safari browser. [vt-addon-no-preview-safari.png](https://uploads.linear.app/cfa7d1b1-ff77-4dbe-ae92-8cf23f92a7a9/ba28d73d-9ce3-4a76-862c-07ce4b41ffa3/9b574a53-96d0-4145-bada-483ffc055285) Checking the dev tools It shows a 401 error, however copying and pasting the URL in a new Safari window loads the URL without any issues. [vt-addon-no-preview-safari-dev-tools.png](https://uploads.linear.app/cfa7d1b1-ff77-4dbe-ae92-8cf23f92a7a9/654e5443-acf1-4335-bd64-e19c8129165e/03a1c2b1-78bd-4fc6-b5d0-52dd9edcd3a3) See the following Slack [conversation](https://chromaticqa.slack.com/archives/C051TQR6QLC/p1691149269232509) for context. *Update: Turning OFF "prevent cross site tracking" 'fixes' the issue:* [image.png](https://uploads.linear.app/cfa7d1b1-ff77-4dbe-ae92-8cf23f92a7a9/033ebbd0-d043-4b63-9a50-04d2987b39fb/90dd73e0-9fe5-4e51-ae9b-20f7f2052e52)