search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Filter out the local build and selected builds if they are from a previous branch #111

Closed tmeasday closed 12 months ago

tmeasday commented 12 months ago

When you switch branches, you'll keep the local build (if you started one) and the selected build (which is pulled by id).

However, they are no longer relevant, so it's better to treat them as if they aren't there.

To QA

  1. On branch-a start a local build
  2. Switch to branch-b (either mid way through or after it finished).
  3. Check you see the empty branch screen & no errors.

  4. Check you can run a build on branch-b.

    📦 Published PR as canary version: 0.0.80--canary.111.ba5c840.0
    :sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.80--canary.111.ba5c840.0 # or yarn add @chromaui/addon-visual-tests@0.0.80--canary.111.ba5c840.0 ```
linear[bot] commented 12 months ago
AP-3671 Weird state when switching branches

I switched to a new branch and was show this in the visual test addon: [image.png](https://uploads.linear.app/cfa7d1b1-ff77-4dbe-ae92-8cf23f92a7a9/e713a883-1b0f-46b5-ace6-28d277f4f7c8/704ef7bd-2b55-42fa-814c-2d9b53db5ce3) The run tests button was active and I clicked it. After the build completed the addon is now back to normal and it appears that the state is correct. I will try to reproduce the issue and add more detail.