search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Setup TurboSnap #115

Closed ghengeveld closed 11 months ago

ghengeveld commented 11 months ago
📦 Published PR as canary version: 0.0.93--canary.115.a91e3de.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.93--canary.115.a91e3de.0 # or yarn add @chromaui/addon-visual-tests@0.0.93--canary.115.a91e3de.0 ```
ghengeveld commented 11 months ago

Why not put the settings in x.config.json and have it apply to the addon too?

@tmeasday What do you mean exactly? I can put onlyChanged and externals in production.config.json but it wouldn't work because the Action doesn't support the config file (at least it doesn't support the configFile option, maybe it does pick up the default?).

You seem to suggest adding TurboSnap support to the addon itself too (so builds run through the addon can use TS)? That seems like a bigger project than what I'm trying to achieve here (speed up our CI builds).

tmeasday commented 11 months ago

Builds through the addon will use turbo snap if it's configured in the config.json. I turned it on for the SB and CH monorepo and and haven't seen any issues yet.

I guess I neglected to add support for the configFile option in the action, we should add that.