ghengeveld
commented
9 months ago I noticed this same bug in this pr. It seems like it resets the controls whenever the the polling reruns #139 (review)
Yes I fixed that on this PR just now. I'll update the other PR to have the latest from this one.
As well, I think we'll need the same context inside the onboarding and maybe other screens one day, so maybe we could add the ControlsContext and BuildContext to a separate directory, like src/state/ so we can easily find them and use them anywhere in the application if needed?
Yeah I've been thinking about centralizing state in its own directory, though I'm not certain about it because in general I prefer to colocate and group by module/feature rather than by technical similarity. Controls should actually live higher up anyway I suppose (because it contains the warnings and settings toggles). For now I'll keep it as-is. We'll undoubtedly revisit it later when we build out more screens.
Telescoping on https://github.com/chromaui/addon-visual-tests/pull/141 Fixes AP-3815
Big refactor to get rid of a lot of prop drilling in favor of useContext. For the selectedBuild behavior I used a reducer.
I wouldn't say this is the final solution but it's making a step in the right direction.
📦 Published PR as canary version:
0.0.116--canary.138.b91410d.0:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.116--canary.138.b91410d.0 # or yarn add @chromaui/addon-visual-tests@0.0.116--canary.138.b91410d.0 ```