chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
31 stars 2 forks source link

Visual Test Addon Onboarding behind query param #144

Closed weeksling closed 6 months ago

weeksling commented 9 months ago

Resolve AP-4116, AP-4126, AP-4127, AP-4133, AP-4115, AP-4110

This adds addon onboarding, with steps:

To enable the onboarding, add the &vtaOnboarding=true query param to your storybook url.

To test, you will want to try this out in these different scenarios:

  1. Create a brand new project on Chromatic (no builds) and add the addon. Onboarding will guide you through creating very first build, making a change, and then the guided tour.
  2. Add the addon to a project with existing builds on Chromatic. Onboarding will skip ahead to make a change and running second build.
  3. Opening a branch with an existing build that has changes. Onboarding will show you the Done screen, and then begin the guided tour (this will be updated to skip ahead to the guided tour without the done screen. Was kept to get a version of the onboarding out - this is a less common edge case).
📦 Published PR as canary version: 1.0.1--canary.144.53a44d0.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@1.0.1--canary.144.53a44d0.0 # or yarn add @chromaui/addon-visual-tests@1.0.1--canary.144.53a44d0.0 ```
paulelliott commented 8 months ago

Invoking the circuit breaker on this PR as it's gone on well past the end date of the project.

JonathanKolnik commented 7 months ago

I'm new to reviewing this repo, if there are easy ways to get it into the right state to QA please let me know!

JonathanKolnik commented 7 months ago

Notes from this case

  1. Add the addon to a project with existing builds on Chromatic. Onboarding will skip ahead to make a change and running second build.

https://github.com/chromaui/addon-visual-tests/assets/1164060/c7853fe5-ce3b-498a-8544-03eccce686cf

weeksling commented 7 months ago

Fixed the image issue and pushed new release 0.0.127-canary.0 - will look at other issues early Monday.