search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
31 stars 2 forks source link

Override any configuration that might cause conflicts #152

Closed ghengeveld closed 8 months ago

ghengeveld commented 9 months ago

Users may have autoAcceptChanges, exitOnceUploaded or exitZeroOnChanges configured in their chromatic.config.json. This PR overrides these values to ensure compatibility with local builds.

📦 Published PR as canary version: 0.0.121--canary.152.c545746.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.121--canary.152.c545746.0 # or yarn add @chromaui/addon-visual-tests@0.0.121--canary.152.c545746.0 ```
weeksling commented 9 months ago

Looks good, but I don't think there should be visual changes UI Tests?

ghengeveld commented 8 months ago

They may not be configurable right now, but they might be in the future. Better to anticipate that.