search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
31 stars 2 forks source link

Get CI green again. #154

Closed tmeasday closed 8 months ago

tmeasday commented 8 months ago

I accidentally pushed an update to SB@7.6.4 to main, which broke CI.

I'm not quite sure what the revert practice is so instead, we should maybe just fix it. This PR

  1. Removes some @ts-expect-errors that were working around an SB bug that got fixed.
  2. Approves changes to colors due to the theme.textMutedColor changing: https://github.com/storybookjs/storybook/pull/24525 (please confirm @MichaelArestad)
  3. There's also this broken story, which was already problematic before the upgrade. Any idea what's happening here @ghengeveld ?
ghengeveld commented 8 months ago

That story isn't broken. It intentionally doesn't show a baseline image because it's loading. We don't have an image loading indicator (yet).